Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77100aa4ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
First-pass review by oxa → oxc → Codex findings
Additional findings
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
|
First-pass REVISE answered: the saving-lock P2 and interrupted-status P3 are fixed with two failing-first regressions (real slow-hook/SIGKILL and a read-only status probe). All 191 touched-crate tests, fmt, strict clippy and four scans pass. The migration P2 is not applicable to this unreleased feature: #336/#358 remain open and #331 explicitly prohibits migration paths. Current-format validation stays strict and preserves unsupported files/worktrees; the inline reply cites that standing rule. Continuing publishing and queue work without a review wait. |
|
First-pass review by oxa → oxc → Codex findings
Additional findings
Defect
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
…failed every command) (#376) * oxa-sandbox: skip git binds whose source vanished mid-session (bwrap failed every command) The 'gh issue view --comments' empty-output half is a gh/mise matter, not oxa. Refs #322 * sandbox: keep a vanished git dir unrecreatable (#322 review) Codex P1 / review P2 confirmed: skipping only the missing gitdir left the common dir bound writable, so the gitdir could be recreated with its own commondir/hooks. A vanished rw git dir now makes all git binds read-only (also in create_missing_git_files_homes). P3 confirmed: existence check follows symlinks, so a dangling symlink is not bound. Test asserts no writable bind over the common dir. No lab/ files are touched by this PR, nothing remains under lab/.
* sandbox: expose the running oxa binary read-only and as OXA_BIN Refs #337 * sandbox: name the running binary OXA_RUNNING_BIN and do not bind it inside the workspace Codex P2 #1 (real): a bind over a binary under the writable workspace makes it a mount point, so a rebuild cannot replace it; it is now only named there. Codex P2 #2 (real): OXA_BIN is the parity suite's explicit override; the sandbox now exports OXA_RUNNING_BIN instead. The first-pass review found no defects. No lab/ files remain (the rename to oxc/ was already merged). * sandbox: skip the read-only exe bind under writable extra paths too, with a test (review finding 1+2)
|
The re-review at f6321b0 confirms the saving-lock fix and finds no further defect beyond migration. The migration request remains inapplicable under #331's standing rule, “No users yet: no legacy names, no migration paths, port or build current behaviour only.” Both predecessor PRs #336/#358 remain open; no released runner state format exists. Current-format checkpoints stay strict and unsupported files/worktrees stay intact. No migration code or test for an intermediate development format will be added. |
* Add opt-in Anthropic event stream translator with final usage * Add stream redactor hooks and require terminal output usage
* Add opt-in in-process gateway Engine adapter * Honor cancellation during buffered reply finalization
# Conflicts: # oxa/oxa-work/src/lib.rs
|
First-pass review by oxa → oxc → Codex findings
Additional findings
TIER: T2 🤖 Generated with Claude Code (oxa review lane) |
…xci-pr) (#423) Pull requests from this repository run their x86_64 jobs on a separate pool of the project's runners when OXCI_PR is on, so they never take a runner the merge queue needs; fork pull requests stay on the hosted images. Claude-Session: https://claude.ai/code/session_01NazrMQ18AoZGWQ7NCTK6ie Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…omponents' heavy jobs) (#432) * ci: path-aware merge queue (classify the group diff, skip untouched components' heavy jobs) tools/ci/paths.py now diffs merge_group.base_sha..head_sha instead of treating a merge group as every file; an empty group diff still counts as everything. oxc-gateway/, oxc-rs/, conformance/ map to the controller (lab) component, fuzz/oxa to oxa, fuzz/oxe to engine; other paths still mark everything. build.yml gains engine/oxa inputs gating engine, flash and the oxa jobs via job-level if (skipped jobs keep their required names); the lab job is gated on the lab output in the queue. Manual and nightly runs are unchanged. cloud-gateway.yml x86_64 jobs use the shared runner expression from checks.yml. * ci: check that no workflow job names a hosted x86_64 image directly tools/ci/tests/test_workflow_runners.py reads every workflow and fails when a job's runs-on is not the hosted ARM image or the runner expression from checks.yml (matrix x86 entries must be routed through it). release.yml and release-build.yml are listed exceptions: published binaries are never built on the project's runners. The failure message shows the expression to copy. build.yml's x86 jobs now use the exact checks.yml expression (fallback ubuntu-latest), and the experimental oxc CLI job moves to the expression too. Check names are unchanged. * ci tests: runner check follows the PR-pool expression Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NazrMQ18AoZGWQ7NCTK6ie --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…th checksums and provenance (#389) * release: attach the combined aarch64 and x86_64 archives and SBOMs with checksums and provenance Fixes #378 * release: map versioned archive to the Arch pkgver name; no cancel of called runs Codex P1 (arch consumers) confirmed: arch-test.sh now copies ox-llm-v*-linux-<arch> to the pkgver name the PKGBUILD expects (same bytes, same hash). Review findings 1 and 2 fixed with tests.
…es saved only on main (#444) * ci: path-gate ready PRs, full main runs, one aggregate gate, main-only cache saves - paths.py: outputs engine/oxa/lab/cli/gateway/md; oxc-rs and conformance map to cli, oxc-gateway to gateway (nothing under oxc/ reads them); push on main, nightly and manual runs set every component; PRs and the queue keep the diff result. - checks.yml: ready PRs run the changed components (heavy on non-draft PRs), conditions on the classifier outputs only; classifier, scans, links, rustfmt and the oxa-tests aggregate on hosted ARM; gateway jobs moved in from cloud-gateway.yml (manual-only now); new gate job. - Caches: actions/cache/restore everywhere, actions/cache/save only on main per key prefix. - tests: test_paths updated, test_gate.py guards gate coverage, flags and cache placement. * session replay: schema check works with jsonschema older than 4.18 The hosted x86_64 image ships a jsonschema without the referencing package; the schema-validation path imported it unconditionally, so the controller suite errored there (it only ever ran where jsonschema was absent and the test was skipped). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NazrMQ18AoZGWQ7NCTK6ie --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
* Add opt-in in-process gateway Engine adapter * Honor cancellation during buffered reply finalization * Exercise core tool loops through the embedded gateway
…357) * TUI: reject unknown slash commands locally; add /help, /usage, /cost Fixes #341 * slash: keep single-component absolute paths (/etc, /README.md) as prompts; test * slash: /help and /usage yield to templates/extensions; drop misleading /cost; tests cover cx.commands and dotless unknown names Codex single-component path finding: /etc and /README.md pass through; a dotless nonexistent name (/srv) is ambiguous with a typo of a command, so it stays a local error (issue #341 asks for exactly that); the test uses a name that cannot exist. * slash: unknown-command error says how to send the line as text (//) Review O-241 P3 (dotless missing path dropped): real; the // escape already reached the core, so the error now names it and a test covers it. P2 (/cost): /cost is deliberately not added (it showed no cost); the PR title is stale, the code and test agree. Nothing lived under lab/. Refs #341 * oxa: unknown slash with text goes to the model, host-independent Review findings: a dotless single-name path (/src explain ...) was dropped locally depending on the host filesystem, and the '//' escape did not restore the line (the core keeps both slashes), so the hint was wrong. Now only a bare unknown /name is rejected; a name followed by text is a prompt. Filesystem check and the false '//' hint removed. /cost: not a built-in (it would show no cost); the PR title should drop it. Nothing under lab/; the change only touches oxa/. * Register /help and /usage in the core command registry; test bare registered commands Review findings: /help and /usage missing from the registry (autocomplete, /help descriptions) - fixed, registry test updated. Tests for /skill:demo and /deploy now use the bare form so the cx.commands lookup is exercised. /cost: no command is added on purpose (it shows no cost); the PR title needs changing, which is done on GitHub. The dotless-relative-name P3: a name followed by text already reaches the model; only a bare unknown name is rejected as a typo. lab/ was already renamed to oxc/ by main; nothing is left under lab/.
|
Superseded by main-based #692 at 43321ee, after #678 landed. The replacement carries the save supervisor's inherited task lock, adds a real parent-death-during-commit-hook regression, and makes status read-only with no flock syscall (fatal-seccomp proof). The new hook regression awaits full CI because this workspace currently refuses thread/fork creation; the earlier 319-test checkpoint run passed. Unsupported formats remain preserved/refused under #331's no-migration rule. Closing this stacked draft; its branch stays intact. |
Delivers step 3 of #333, stacked on #358. T2.
The runner saves staged, unstaged and untracked task work as a normal commit, including after failed checks. Hooks and the configured identity remain in force; rejected commits and unresolved conflicts retain all work and block the task. Atomic owner-only per-task checkpoints resume interrupted phases with their captured task/base/check commands. Completed tasks skip unless --rerun is explicit; --status prints ID, outcome, last progress time and current step.
Kernel locks survive a killed runner through agent, acceptance and saving subprocesses. Status probes ownership so an interrupted unlocked phase reports blocked without rewriting its checkpoint.
Validation at 94fb542 (normal merges of the updated step 2 and the maintainer's main update): 194 touched-crate tests pass, plus full-workspace fmt, strict all-target clippy and four unchanged scans. Actual SIGKILL/slow-hook regressions failed before their fixes. Tests use fake engines, real bwrap and local bare repositories.
No runner state format has shipped: #336/#358 are open. Required current-format fields remain strict under #331's explicit no-migration rule; unsupported files and retained worktrees are not overwritten or deleted.